lib: do not crash using workers with disabled shared array buffers#41023
Merged
aduh95 merged 1 commit intonodejs:mainfrom Feb 18, 2023
Merged
Conversation
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Nov 29, 2021
tniessen
approved these changes
Nov 29, 2021
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
It would be great if you could add a comment to these explaining why it's necessary since I don't think it's going to be obvious to someone reading the code. Especially the first occurrence that does not reference SAB directly.
Member
Author
|
I missed the prior work by @codebytere #39718. I might also have found the issue that blocked the PR from being merged. I'll try that later on. |
BridgeAR
force-pushed
the
do-not-crash-with-disabled-shared-array-buffer
branch
3 times, most recently
from
73059c2 to
a39f548
Compare
github-actions
bot
removed
the
request-ci
Collaborator
46 tasks
Collaborator
47 tasks
Collaborator
BridgeAR
force-pushed
the
do-not-crash-with-disabled-shared-array-buffer
branch
from
a39f548 to
f26a4d0
Compare
github-actions
bot
removed
the
request-ci
Collaborator
46 tasks
Collaborator
This was referenced Dec 10, 2021
Member
Author
This was referenced Dec 12, 2021
This was referenced Sep 1, 2022
This allows the repl to function normally while using the `--no-harmony-sharedarraybuffer` V8 flag. It also fixes using workers while using the `--no-harmony-atomics` V8 flag. Fixes: nodejs#39717 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
BridgeAR
force-pushed
the
do-not-crash-with-disabled-shared-array-buffer
branch
from
9c2ceb6 to
ed3865f
Compare
BridgeAR
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
aduh95
approved these changes
Feb 17, 2023
Member
|
@BridgeAR is this still something you want to move forward? We still float the patch so it's definitely still useful to Electron! |
Member
Author
|
@codebytere I just rebased the branch and started the CI to land this :) |
Collaborator
Collaborator
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41023 ✔ Done loading data for nodejs/node/pull/41023 ----------------------------------- PR info ------------------------------------ Title lib: do not crash using workers with disabled shared array buffers (#41023) Author Ruben Bridgewater (@BridgeAR) Branch BridgeAR:do-not-crash-with-disabled-shared-array-buffer -> nodejs:main Labels author ready, worker, needs-ci Commits 1 - lib: do not crash using workers with disabled shared array buffers Committers 1 - Ruben Bridgewater PR-URL: https://github.com/nodejs/node/pull/41023 Fixes: https://github.com/nodejs/node/issues/39717 Reviewed-By: James M Snell Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41023 Fixes: https://github.com/nodejs/node/issues/39717 Reviewed-By: James M Snell Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 29 Nov 2021 21:01:08 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41023#pullrequestreview-818336803 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41023#pullrequestreview-818394046 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41023#pullrequestreview-1304031055 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2023-02-18T08:32:07Z: https://ci.nodejs.org/job/node-test-pull-request/49675/ - Querying data for job/node-test-pull-request/49675/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4210704839 |
Contributor
|
Landed in fbd55a8 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
This allows the repl to function normally while using the `--no-harmony-sharedarraybuffer` V8 flag. It also fixes using workers while using the `--no-harmony-atomics` V8 flag. Fixes: #39717 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #41023 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2023
This allows the repl to function normally while using the `--no-harmony-sharedarraybuffer` V8 flag. It also fixes using workers while using the `--no-harmony-atomics` V8 flag. Fixes: #39717 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #41023 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
This allows the repl to function normally while using the `--no-harmony-sharedarraybuffer` V8 flag. It also fixes using workers while using the `--no-harmony-atomics` V8 flag. Fixes: #39717 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #41023 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 14, 2023
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 17, 2023
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 18, 2023
* chore: bump node in DEPS to v18.16.0 * build,test: add proper support for IBM i nodejs/node#46739 * lib: enforce use of trailing commas nodejs/node#46881 * src: add initial support for single executable applications nodejs/node#45038 * lib: do not crash using workers with disabled shared array buffers nodejs/node#41023 * src: remove shadowed variable in OptionsParser::Parse nodejs/node#46672 * src: allow embedder control of code generation policy nodejs/node#46368 * src: allow optional Isolate termination in node::Stop() nodejs/node#46583 * lib: fix BroadcastChannel initialization location nodejs/node#46864 * chore: fixup patch indices * chore: sync filenames.json * fix: add simdutf dep to src/inspector BUILD.gn - nodejs/node#46471 - nodejs/node#46472 * deps: replace url parser with Ada nodejs/node#46410 * tls: support automatic DHE nodejs/node#46978 * fixup! src: add initial support for single executable applications * http: unify header treatment nodejs/node#46528 * fix: libc++ buffer overflow in string_view ctor nodejs/node#46410 * test: include strace openat test nodejs/node#46150 * fixup! fixup! src: add initial support for single executable applications --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the repl to function normally while using the
--no-harmony-sharedarraybufferV8 flag.Fixes: #39717
Signed-off-by: Ruben Bridgewater ruben@bridgewater.de